Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

bank: Prune older epoch stakes#7668

Merged
mvines merged 2 commits intosolana-labs:masterfrom
mvines:rm
Jan 4, 2020
Merged

bank: Prune older epoch stakes#7668
mvines merged 2 commits intosolana-labs:masterfrom
mvines:rm

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Jan 3, 2020

Fixes #6991

@mvines

This comment has been minimized.

@codecov

This comment has been minimized.

@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Jan 4, 2020

🐣

@mvines mvines marked this pull request as ready for review January 4, 2020 05:39
@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Jan 4, 2020

Thanks @ryoqun, I pulled in most of #7098. I found no need for your changes in ledger/src/leader_schedule_cache.rs so I dropped those hunks

Comment thread runtime/src/bank.rs

pub const SECONDS_PER_YEAR: f64 = (365.25 * 24.0 * 60.0 * 60.0);

pub const MAX_LEADER_SCHEDULE_STAKES: Epoch = 5;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5? 🤷‍♂ - I have no reason for 5 over any other number at the moment

@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Jan 4, 2020

@rob-solana or @sagar-solana - would you mind quickly scanning this PR? It's pretty close to @ryoqun's original work

@mvines mvines removed the v0.21 label Jan 4, 2020
@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Jan 4, 2020

I'm going to land this to get some test mileage on it before TdS DR6 on Tuesday. Post-merge review very welcome!

@mvines mvines merged commit e782c26 into solana-labs:master Jan 4, 2020
solana-grimes pushed a commit that referenced this pull request Jan 4, 2020
@ryoqun
Copy link
Copy Markdown
Contributor

ryoqun commented Jan 6, 2020

LGTM

@rob-solana
Copy link
Copy Markdown
Contributor

the only thing holding up @ryoqun's PR was a disposition for absent epoch stakes via RPC. if that's covered now, all good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bank.epoch_stakes grows without bound

3 participants